| Violation | Line |
|---|---|
| NP: Load of known null value in org.zilverline.core.AbstractCollection.getNumberOfDocs() | 416 |
| EI: org.zilverline.core.AbstractCollection.getLastIndexed() may expose internal representation by returning org.zilverline.core.AbstractCollection.lastIndexed | 362 |
| Nm: Confusing to have methods org.zilverline.core.AbstractCollection.getUrl() and org.zilverline.core.Result.getURL() | 0 |
| Violation | Line |
|---|---|
| Dm: Method org.zilverline.core.ExtractorFactory.canExtract(java.io.File) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 116 |
| Dm: Method org.zilverline.core.ExtractorFactory.canExtract(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 135 |
| Dm: Method org.zilverline.core.ExtractorFactory.createExtractor(java.io.File) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 157 |
| Dm: Method org.zilverline.core.ExtractorFactory.createExtractor(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 233 |
| Dm: Method org.zilverline.core.ExtractorFactory.setMappings(java.util.Map) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 284 |
| Violation | Line |
|---|---|
| REC: Method org.zilverline.core.FileSystemCollection.indexFile(java.io.File) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 266 |
| Violation | Line |
|---|---|
| Dm: Method org.zilverline.core.Handler.canUnPack(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 86 |
| Dm: Method org.zilverline.core.Handler.getUnArchiveCommand(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 105 |
| Dm: Method org.zilverline.core.Handler.setMappings(java.util.Map) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 160 |
| Violation | Line |
|---|---|
| Dm: Method org.zilverline.core.IMAPCollection.indexPart(org.apache.lucene.document.Document,javax.mail.Part) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 477 |
| Dm: Method org.zilverline.core.IMAPCollection.indexString(org.apache.lucene.document.Document,String,String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 534 |
| DLS: Dead store to $l5 in method org.zilverline.core.IMAPCollection.indexMimeMessage(org.apache.lucene.document.Document,javax.mail.internet.MimeMessage) | 447 |
| DLS: Dead store to size in method org.zilverline.core.IMAPCollection.indexPart(org.apache.lucene.document.Document,javax.mail.Part) | 462 |
| REC: Method org.zilverline.core.IMAPCollection.doIndex(boolean) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 261 |
| REC: Method org.zilverline.core.IMAPCollection.indexFolder(org.apache.lucene.index.IndexWriter,javax.mail.Folder) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 326 |
| Violation | Line |
|---|---|
| EI: org.zilverline.core.Result.getModificationDate() may expose internal representation by returning org.zilverline.core.Result.modificationDate | 150 |
| EI2: org.zilverline.core.Result.setModificationDate(java.util.Date) may expose internal representation by storing an externally mutable object into org.zilverline.core.Result.modificationDate | 311 |
| Nm: Confusing to have methods org.zilverline.core.Result.setURL(String) and org.zilverline.core.AbstractCollection.setUrl(String) | 0 |
| Violation | Line |
|---|---|
| EI2: org.zilverline.core.SearchResult.<init>(Result[],int,int,int) may expose internal representation by storing an externally mutable object into org.zilverline.core.SearchResult.results | 45 |
| EI: org.zilverline.core.SearchResult.getResults() may expose internal representation by returning org.zilverline.core.SearchResult.results | 78 |
| Violation | Line |
|---|---|
| REC: Method org.zilverline.extractors.ExcelExtractor.getContent(java.io.File) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 93 |
| Violation | Line |
|---|---|
| XFB: Method org.zilverline.extractors.HTMLExtractor.getContent(java.io.File) directly allocates a specific implementation of xml interfaces | 60 |
| XFB: Method org.zilverline.extractors.HTMLExtractor.getContent(java.io.InputStream) directly allocates a specific implementation of xml interfaces | 98 |
| XFB: Method org.zilverline.extractors.HTMLExtractor.getContent(String) directly allocates a specific implementation of xml interfaces | 123 |
| Violation | Line |
|---|---|
| REC: Method org.zilverline.extractors.PowerPointExtractor.getContent(java.io.File) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 66 |
| REC: Method org.zilverline.extractors.PowerPointExtractor.processPOIFSReaderEvent(org.apache.poi.poifs.eventfilesystem.POIFSReaderEvent) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 113 |
| Violation | Line |
|---|---|
| Dm: Method org.zilverline.lucene.BoostFactor.setFactors(java.util.Map) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 92 |
| Violation | Line |
|---|---|
| Dm: Method org.zilverline.lucene.BoostingParser.getFieldQuery(String,org.apache.lucene.analysis.Analyzer,String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 119 |
| Violation | Line |
|---|---|
| Nm: The method name org.apache.lucene.queryParser.QueryParser.Conjunction() doesn't start with an lower case letter | 726 |
| Nm: The method name org.apache.lucene.queryParser.QueryParser.Modifiers() doesn't start with an lower case letter | 754 |
| Nm: The method name org.apache.lucene.queryParser.QueryParser.Query(String) doesn't start with an lower case letter | 787 |
| Nm: The method name org.apache.lucene.queryParser.QueryParser.Clause(String) doesn't start with an lower case letter | 832 |
| Nm: The method name org.apache.lucene.queryParser.QueryParser.Term(String) doesn't start with an lower case letter | 881 |
| Nm: The method name org.apache.lucene.queryParser.QueryParser.ReInit(CharStream) doesn't start with an lower case letter | 1172 |
| Nm: The method name org.apache.lucene.queryParser.QueryParser.ReInit(QueryParserTokenManager) doesn't start with an lower case letter | 1190 |
| Violation | Line |
|---|---|
| UI: Usage of GetResource in org.zilverline.service.CollectionManagerImpl.<init>() may be unsafe if class is extended | 151 |
| EI: org.zilverline.service.CollectionManagerImpl.getAllAnalyzers() may expose internal representation by returning org.zilverline.service.CollectionManagerImpl.allAnalyzers | 478 |
| EI: org.zilverline.service.CollectionManagerImpl.getAllExtractors() may expose internal representation by returning org.zilverline.service.CollectionManagerImpl.allExtractors | 790 |
| OS: org.zilverline.service.CollectionManagerImpl.unZip(java.io.File,org.zilverline.core.FileSystemCollection) may fail to close stream on exception | 740 |
| OS: org.zilverline.service.CollectionManagerImpl.unZip(java.io.File,org.zilverline.core.FileSystemCollection) may fail to close stream on exception | 746 |
| UCF: Useless control flow in org.zilverline.service.CollectionManagerImpl.init() | 373 |
| REC: Method org.zilverline.service.CollectionManagerImpl.unZip(java.io.File,org.zilverline.core.FileSystemCollection) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 763 |
| Violation | Line |
|---|---|
| EI: org.zilverline.service.SearchServiceImpl.getAllBoostableFields() may expose internal representation by returning org.zilverline.service.SearchServiceImpl.allBoostableFields | 490 |
| REC: Method org.zilverline.service.SearchServiceImpl.doSearch(String[],String,int,int) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 289 |
| REC: Method org.zilverline.service.SearchServiceImpl.doSearch(String[],String,int,int) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 289 |
| UwF: Field not initialized in constructor: org.zilverline.service.SearchServiceImpl.collectionManager | 0 |
| UwF: Field not initialized in constructor: org.zilverline.service.SearchServiceImpl.dao | 0 |
| Violation | Line |
|---|---|
| ITA: Method org.zilverline.util.ClassFinder.getInstantiableSubclasses(Class) uses Collection.toArray() with zero-length array argument | 123 |
| ITA: Method org.zilverline.util.ClassFinder.addJarsInPath(String[]) uses Collection.toArray() with zero-length array argument | 152 |
| Violation | Line |
|---|---|
| REC: Method org.zilverline.util.SysUtils.canExecute(String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 318 |
| REC: Method org.zilverline.util.SysUtils.execute(String,java.io.File,java.io.File) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 402 |
| Violation | Line |
|---|---|
| EI: org.zilverline.web.CollectionForm.getNames() may expose internal representation by returning org.zilverline.web.CollectionForm.names | 44 |
| EI2: org.zilverline.web.CollectionForm.setNames(String[]) may expose internal representation by storing an externally mutable object into org.zilverline.web.CollectionForm.names | 53 |
| Violation | Line |
|---|---|
| DLS: Dead store to collection in method org.zilverline.web.CollectionValidator.validate(Object,org.springframework.validation.Errors) | 43 |
| Violation | Line |
|---|---|
| REC: Method org.zilverline.web.HandlerValidator.validate(Object,org.springframework.validation.Errors) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 109 |
| Violation | Line |
|---|---|
| REC: Method org.zilverline.web.SearchController.onSubmit(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse,Object,org.springframework.validation.BindException) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 171 |
| Violation | Line |
|---|---|
| DLS: Dead store to $l12 in method org.zilverline.web.SearchDefaultsController.onSubmit(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse,Object,org.springframework.validation.BindException) | 128 |
| UwF: Field not initialized in constructor: org.zilverline.web.SearchDefaultsController.service | 0 |
| Violation | Line |
|---|---|
| EI: org.zilverline.web.SearchForm.getCollections() may expose internal representation by returning org.zilverline.web.SearchForm.collections | 128 |
| EI2: org.zilverline.web.SearchForm.setCollections(CollectionTriple[]) may expose internal representation by storing an externally mutable object into org.zilverline.web.SearchForm.collections | 135 |
| EI: org.zilverline.web.SearchForm.getEndDate() may expose internal representation by returning org.zilverline.web.SearchForm.endDate | 142 |
| EI2: org.zilverline.web.SearchForm.setEndDate(java.util.Date) may expose internal representation by storing an externally mutable object into org.zilverline.web.SearchForm.endDate | 149 |
| EI: org.zilverline.web.SearchForm.getStartDate() may expose internal representation by returning org.zilverline.web.SearchForm.startDate | 156 |
| EI2: org.zilverline.web.SearchForm.setStartDate(java.util.Date) may expose internal representation by storing an externally mutable object into org.zilverline.web.SearchForm.startDate | 163 |
| Violation | Line |
|---|---|
| RCN: Nullcheck of value previously dereferenced org.zilverline.web.UploadValidator.validate(Object,org.springframework.validation.Errors) | 53 |
| Violation | Line |
|---|---|
| NP: Load of known null value in org.zilverline.dao.xstream.CollectionManagerXStreamDAOImpl.load() | 115 |
| DLS: Dead store to manager in method org.zilverline.dao.xstream.CollectionManagerXStreamDAOImpl.load() | 115 |
| Violation | Line |
|---|---|
| UwF: Field not initialized in constructor: org.zilverline.core.ParsedFileInfo.file | 0 |
| Violation | Line |
|---|---|
| UwF: Field not initialized in constructor: org.zilverline.service.IndexServiceImpl.collectionManager | 0 |
| Violation | Line |
|---|---|
| UwF: Field not initialized in constructor: org.zilverline.web.IndexController.indexService | 0 |
| Violation | Line |
|---|---|
| UwF: Field not initialized in constructor: org.zilverline.web.ZilverController.collectionManager | 0 |